[WIP] Add error messages for unsupported macro features on compilation #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-features-on-compilation
CodSpeed Performance ReportMerging #3993 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Mar 26, 2024
Comment on lines
+187
to
+191
| if is_abi3() && python_version >= PY_3_9 { | ||
| set_option!(weakref); | ||
| } else { | ||
| return Err(syn::Error::new((weakref.span()), "`weakref` not supported until python 3.9 or graeter",)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if is_abi3() && python_version >= PY_3_9 { | |
| set_option!(weakref); | |
| } else { | |
| return Err(syn::Error::new((weakref.span()), "`weakref` not supported until python 3.9 or graeter",)); | |
| } | |
| if python_version >= PY_3_9 || !is_abi3() { | |
| set_option!(weakref); | |
| } else { | |
| return Err(syn::Error::new((weakref.span()), "`weakref` not supported with `abi3` until python 3.9 or graeter",)); | |
| } |
|
Continued in #4194. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to issue #3945
Returning an error message when calling an unsupported macro feature in compilation.
Currently only doing so for
weakref.